CoreBOSBB

Full Version: Can't delete releted to do
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Hi,

Look like a bug, Also happen  in Corebos demo.

I create two "to do"s the 2nd related to the 1st.

Pressing "del" link of related "to do" in "More information" don't delete it.
I didn't find any relevant JS error in the browser console.

Attach screenshot
This isn't really an error. This is how it has always "worked". We inherited that functionality from vtiger CRM and have never got around to changing it. Mostly because I wanted to redesign the whole functionality on those lists.

The functionality is that the "delete" is trying to un-relate the two records. The action is not to delete the record you are seeing but since you are on a related list, it tries to un-relate them.

Now, that isn't a bad idea in itself, it brings the idea that we need two actions, one to delete the record and one to unrelate them. But there is much more. In this case, it doesn't unrelate them because they have a direct relation, so it would have to leave the capture field on the first record empty. That is ok for the Calendar-Calendar relation because the field CAN be empty but it is not a valid operation to do on and invoice (for example), where we would leave the Invoice without an Account which is not valid.

Now, it gets even more interesting because depending on what related list you are on the (still present) vtiger crm code takes different actions giving the delete link different functionality depending on where you are.

So, in short, what needs to be done is redesign the functionality of the related lists, giving the user all the options and information they need to execute the action they are looking for and then review all the code in all the modules to standardize it to this design. We will get to it eventually. In fact, we are very close now. The new data table for the list view is almost ready, that will bring a significant speed improvement along with some nice functionlity (inline edit in the list view similar to a spreadsheet). Once we have that we will copy this functionality to the related lists and redesign the process.

Patience.
in the meantime, go into the record and delete it from there
Thank you for the detail explanation.
(06-07-2020, 11:08 PM)joebordes Wrote: [ -> ]This isn't really an error. This is how it has always "worked". We inherited that functionality from vtiger CRM and have never got around to changing it. Mostly because I wanted to redesign the whole functionality on those lists.

The functionality is that the "delete" is trying to un-relate the two records. The action is not to delete the record you are seeing but since you are on a related list, it tries to un-relate them.

Now, that isn't a bad idea in itself, it brings the idea that we need two actions, one to delete the record and one to unrelate them. But there is much more. In this case, it doesn't unrelate them because they have a direct relation, so it would have to leave the capture field on the first record empty. That is ok for the Calendar-Calendar relation because the field CAN be empty but it is not a valid operation to do on and invoice (for example), where we would leave the Invoice without an Account which is not valid.

Now, it gets even more interesting because depending on what related list you are on the (still present) vtiger crm code takes different actions giving the delete link different functionality depending on where you are.

So, in short, what needs to be done is redesign the functionality of the related lists, giving the user all the options and information they need to execute the action they are looking for and then review all the code in all the modules to standardize it to this design. We will get to it eventually. In fact, we are very close now. The new data table for the list view is almost ready, that will bring a significant speed improvement along with some nice functionlity (inline edit in the list view similar to a spreadsheet). Once we have that we will copy this functionality to the related lists and redesign the process.

Patience.

New related list is very good improvement !