+- CoreBOSBB (https://discussions.corebos.org)
+-- Forum: Development (https://discussions.corebos.org/forumdisplay.php?fid=18)
+--- Forum: coreBOS Development (https://discussions.corebos.org/forumdisplay.php?fid=4)
+--- Thread: Project task progress adds "25" (/showthread.php?tid=407)
Project task progress adds "25" - Guido1982 - 09-07-2016
When I update a project task progress (pretty up-to-date install), the number "25" is added to the percentage, resulting in (for instance) "40%25".. No idea how this happens...
RE: Project task progress adds "25" - omarllorens - 09-07-2016
Thanks for inform! I've reproduced the error and I've fixed it.
You can update your code and try again.
Fixed here: https://github.com/tsolucio/corebos/commit/630a798badfbb1f577b29dce8e51a4c7aada03d5
RE: Project task progress adds "25" - Guido1982 - 09-08-2016
No problem, thanks for fixing. Just a question: the 'escapeAll' and 'escapeURIComponent' functions, are they 'vtiger' functions?
RE: Project task progress adds "25" - joebordes - 09-08-2016
escapeAll is vtiger crm function which I have put on my to-do list to eliminate, it is a manual (and incorrect) way of doing the standard javascript escapeURIComponent() and encodeURI() functions, which is what should have been used from the start.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent
It won't be long before I eliminate that....
RE: Project task progress adds "25" - Guido1982 - 09-08-2016
Come to think of it, the two escapeURI functions were just handled in the javascript book I'm reading...
RE: Project task progress adds "25" - joebordes - 09-08-2016
turns out it was only being used in two other places. one is useless because it is the chat box which is all broken (and always has been) the other I have taken care of:
https://github.com/tsolucio/corebos/commit/939a611559664915518e14bdb3e8bc9b59e8c86f