some small improvements - Printable Version

some small improvements - Printable Version

+- CoreBOSBB (https://discussions.corebos.org)
+-- Forum: Development (https://discussions.corebos.org/forumdisplay.php?fid=18)
+--- Forum: coreBOS Development (https://discussions.corebos.org/forumdisplay.php?fid=4)
+---- Forum: coreBOS (https://discussions.corebos.org/forumdisplay.php?fid=5)
+---- Thread: some small improvements (/showthread.php?tid=55)

some small improvements - saidmsl - 09-15-2014

hi, is it possible to add the following in github :

1. mail receipt : when sending an email , it's good to know it the recipient has read or just deleted the email, good for marketing purpose

affected file : modules/Emails/mail.php
line 72 : add
$mail->ConfirmReadingTo = $mail->From; //MSL

2. order the widgets by sequence

affected file : vtlib/Vtiger/Link.php
function getAllTypes
static function getAllByType($tabid, $type=false, $parameters=false) {
global $adb, $current_user;
self::__initSchema();

$multitype = false;
$orderby = " order by linktype,sequence"; //MSL

if($type) {
// Multiple link type selection?
if(is_array($type)) {
$multitype = true;
if($tabid === self::IGNORE_MODULE) {
$sql = 'SELECT * FROM vtiger_links WHERE linktype IN ('.
Vtiger_Utils::implodestr('?', count($type), ',') .') ';
$params = $type;
$permittedTabIdList = getPermittedModuleIdList();
if(count($permittedTabIdList) > 0 && $current_user->is_admin !== 'on') {
$sql .= ' and tabid IN ('.
Vtiger_Utils::implodestr('?', count($permittedTabIdList), ',').')';
$params[] = $permittedTabIdList;
}
$result = $adb->pquery($sql . $orderby , Array($adb->flatten_array($params))); //MSL
} else {
$result = $adb->pquery('SELECT * FROM vtiger_links WHERE tabid=? AND linktype IN ('.
Vtiger_Utils::implodestr('?', count($type), ',') .')' . $orderby,
Array($tabid, $adb->flatten_array($type))); //MSL
}
} else {
// Single link type selection
if($tabid === self::IGNORE_MODULE) {
$result = $adb->pquery('SELECT * FROM vtiger_links WHERE linktype=?' . $orderby, Array($type)); //MSL
} else {
$result = $adb->pquery('SELECT * FROM vtiger_links WHERE tabid=? AND linktype=?' . $orderby, Array($tabid, $type)); //MSL
}
}
} else {
$result = $adb->pquery('SELECT * FROM vtiger_links WHERE tabid=?' . $orderby, Array($tabid)); //MSL
}

then set the order in the vtiger_links directly

more to come ...

Re: some small improvements - joebordes - 09-15-2014

Can you make Pull Requests for these changes? I mean that is one of the main benefits of using GitHub.

I will try to keep up with you here but pull requests would be much easier. Ask for help, I know it is daunting at the beginning <img src="{SMILIES_PATH}/icon_e_smile.gif" alt=":-)" title="Smile" />

Re: some small improvements - saidmsl - 09-17-2014

how to do that?

Re: some small improvements - joebordes - 09-17-2014

Ok, really high level:

- create yourself a git account and log in
- go to the corebos project and create a fork for yourself
- clone your fork into your development machine: git clone <a class="postlink" href="https://github.com/...">https://github.com/...</a>.
- install your cloned/local version and get everything ready to work and test
- that was the "do once/initialization"
- now each time you want to develop a new feature you have to:
- git checkout -b my_new_feature_branch
- that creates a new branch where you can develop and test
- once it is finished you commit your changes to the branch:
- git add {new files}
- git commit -m "your message"
- now you go to your project in github and select the branch, you will see that you have a "Pull Request" button there which will hand hold you through the rest of the project

There is a lot of GIT here, it is extremely important that you dedicate some time to learning git, not only for contributing to the project but also for maintaining your installs: it is a VERY powerful and useful tool that will help you keep all your installs up to date easily.

Patience <img src="{SMILIES_PATH}/icon_e_smile.gif" alt=":-)" title="Smile" />
Keep asking

Re: some small improvements - saidmsl - 09-18-2014

Hi,

will try it , never used git

rgds

Re: some small improvements - saidmsl - 09-18-2014

Hi,

Very happy , my first commit in github, hurray !!!!

i have added a simple feature : add activities to vendors

Rgds

Re: some small improvements - saidmsl - 10-03-2014

Hi,

i have followed your tutorial

i 'm creating a new branch

but how to merge it to master so that any other changes will not be messed up with old changes?

Rgds

Re: some small improvements - joebordes - 10-08-2014

have a look here:

<a class="postlink" href="https://github.com/tsolucio/corebos/pull/30#issuecomment-58338472">https://github.com/tsolucio/corebos/pul ... t-58338472</a>

<a class="postlink" href="http://youtu.be/EtlVsa83HvQ">http://youtu.be/EtlVsa83HvQ</a>

and ask for whatever help you may need.

Re: some small improvements - saidmsl - 11-08-2014

Hi,

i messed up with github and it's pain commiting (it's commit files that i do not want to commit)

here is the patch for vendor activities links against corebos version dated 2/11/2014

if someone can commit it to the main repositry, it would be great

i have tested it and it works fine

rgds

Re: some small improvements - joebordes - 01-04-2015

Hi

I finally got around to adding this. Really sorry for taking so long.

<a class="postlink" href="https://github.com/tsolucio/corebos/commit/aef5145afe132d106186dcd59451d6d83b5477d3">https://github.com/tsolucio/corebos/com ... d83b5477d3</a>

Joe
TSolucio