+- CoreBOSBB (https://discussions.corebos.org)
+-- Forum: Open (https://discussions.corebos.org/forumdisplay.php?fid=20)
+--- Forum: Open Discussions (https://discussions.corebos.org/forumdisplay.php?fid=10)
+--- Thread: corebosreportico (/showthread.php?tid=68)
corebosreportico - saidmsl - 11-25-2014
Hi,
i have tested the reportico integration, quite impressive , some suggestions :
- i have attached a config.php that will read the config.inc.php
- already create a project folder corebos with the config.php preloaded (and deny creation of a new project)
- set the project name to corebos when registering a report
- for administration, automatically login the admin (ie do not ask for the password) if user logged in corebos is an administrator
- put the smarty templates and templates_c under /corebos/Smarty/templates/modules/cbreportico
- maybe : scan the project folder an automatically populate the modules records
- maybe : save the content of the report in the db instead of in the xml file
rgds
Re: corebosreportico - saidmsl - 11-25-2014
sorry, i didn't find the framework mode
so my config is useless.
another suggestion : use adodb provided by corebos , it can light up the files
Re: corebosreportico - omarllorens - 11-25-2014
Hi.
First, thank you for your feedback and suggestions. <!-- s
--><img src="{SMILIES_PATH}/icon_e_biggrin.gif" alt="" title="Very Happy" /><!-- s --> I will try to answer you all your points.
- already create a project folder corebos with the config.php preloaded (and deny creation of a new project)
Is not necessary to add an other config script. Now you have the corebosrun.php that is in install folder and that you have to paste into modules/cbReportico/reportico/ directory.
This script is called from our script modules/cbReportico/ReporticoView.php. We do this for not modify the run.php into reportico.
About to create corebos project and not permit to create more projects, sounds good but I left this possibility open because I think is a good idea to have the possibility to create more projects to separates reports types. Like project for Opportunities reports, for Invoices, HelpDesk,... By this way it's more easy to create filters into Reportico module, to assing a some users or group that just have permission to use Inventory Reports, to export a HelpDesk projecto for an other coreBOS installation with Reportico,...
- for administration, automatically login the admin (ie do not ask for the password) if user logged in corebos is an administrator
This is a good idea. Maybe just set the admin password the first time to reportico for save in any place and after if you arar a coreBOS admin user set this password automactically.
- put the smarty templates and templates_c under /corebos/Smarty/templates/modules/cbreportico
Sorry, but I don't understand the reason for doing so. The corebo/Smarty/templates/modules/cbReportico/ is if you want to modify the frontend when access to a module, but in this case our frontend is the ListView and Detailview to create/edit/execute reports. Reportico have its own frontend that is embedded into cbReportico module when execute action=ReporticoView.php.
Can you send me an example to understand the advantage of doing so, please?
- maybe : scan the project folder an automatically populate the modules records
I like this, it's a good idea to save work for the administrator. Create a rigister in the module with the basic information to execute the report, and if you want to set some parameters like hide criteria just you have to edit. <!-- s
--><img src="{SMILIES_PATH}/icon_e_smile.gif" alt="" title="Smile" /><!-- s --> - maybe : save the content of the report in the db instead of in the xml file
This is not just convinced me, because with this you have to change the way to operate with reportico and modify reportico to execute the report. The idea of the integration is, that you can dowload a new reporitco versioin into your cbReportico module and use it with the minimus changes.
-use adodb provided by corebos , it can light up the files
Maybe in the near future when we update coreBOS adodb to a more modern version
Thanks again for you support.
Regards,
Omar.
Re: corebosreportico - omarllorens - 11-25-2014
I've attached a image for you can see the framework mode.
Re: corebosreportico - saidmsl - 11-25-2014
hi,
thanks
prior knowing you were making the integration, i have started to make my own changes with different ( and basic) way :
- use librairies provided by corebos : adodb and smarty , just to unify and use only one version of the libraries
- move the templates of reportico in modules/reportico (just to have a clean way to find files)
- i used a iframe to embed a reports as a module
- already create a project folder corebos with the config.php preloaded (and deny creation of a new project)
Is not necessary to add an other config script. Now you have the corebosrun.php that is in install folder and that you have to paste into modules/cbReportico/reportico/ directory.
This script is called from our script modules/cbReportico/ReporticoView.php. We do this for not modify the run.php into reportico.
About to create corebos project and not permit to create more projects, sounds good but I left this possibility open because I think is a good idea to have the possibility to create more projects to separates reports types. Like project for Opportunities reports, for Invoices, HelpDesk,... By this way it's more easy to create filters into Reportico module, to assing a some users or group that just have permission to use Inventory Reports, to export a HelpDesk projecto for an other coreBOS installation with Reportico,...
YEs, sorry, i did not at the files.
- for administration, automatically login the admin (ie do not ask for the password) if user logged in corebos is an administrator
This is a good idea. Maybe just set the admin password the first time to reportico for save in any place and after if you arar a coreBOS admin user set this password automactically.
- put the smarty templates and templates_c under /corebos/Smarty/templates/modules/cbreportico
Sorry, but I don't understand the reason for doing so. The corebo/Smarty/templates/modules/cbReportico/ is if you want to modify the frontend when access to a module, but in this case our frontend is the ListView and Detailview to create/edit/execute reports. Reportico have its own frontend that is embedded into cbReportico module when execute action=ReporticoView.php.
Can you send me an example to understand the advantage of doing so, please?
the advantages is to know where the files are. and have a unity with other modules but as you say below, it will break future udpates
- maybe : scan the project folder an automatically populate the modules records
I like this, it's a good idea to save work for the administrator. Create a rigister in the module with the basic information to execute the report, and if you want to set some parameters like hide criteria just you have to edit. <!-- s
--><img src="{SMILIES_PATH}/icon_e_smile.gif" alt="" title="Smile" /><!-- s --> - maybe : save the content of the report in the db instead of in the xml file
This is not just convinced me, because with this you have to change the way to operate with reportico and modify reportico to execute the report. The idea of the integration is, that you can dowload a new reporitco versioin into your cbReportico module and use it with the minimus changes.
OK , agree, i was just thinking for backup : ie you backup the mysql and you have all data
-use adodb provided by corebos , it can light up the files
Maybe in the near future when we update coreBOS adodb to a more modern version
Re: corebosreportico - saidmsl - 11-26-2014
Hi,
here is the file that do populate the module
to do :
- add a button in listview
- do not read admin, northwind and tutorials projects
it will set default values :
mode = prepare and output = HTML
should be good to add a name in the cbreportico instead using the xml file name , reports can then have a better explanation
Re: corebosreportico - omarllorens - 11-26-2014
Thanks!
I've added your contribution to the project and upload to github. You can see the commit here: <!-- m --><a class="postlink" href="https://github.com/tsolucio/coreBOSReportico/commit/15be726fa43b45fc19001f3227e6afc10b187f1e">https://github.com/tsolucio/coreBOSRepo ... c10b187f1e</a><!-- m -->
The todo is finish too.
- I've added a cumtomlink in the module's manifest.xml to create the button in the listview.
- I check if the folder is admin, tutorials, northwind and check if the directory name start with a dot, maybe if you have .svn, .git ,.... for no add to corebos.
- I've added a check permiision. Just if your are admin user in corebos you will can execute the getreports.php.
- And finally , now exist an other field to save the reportname.xml called xmlreport and the old report field is to save the Report Tittle. The report title and description get the value from the reportname.xml. You can see this in the new getreports.php.
Thanks again.
Re: corebosreportico - saidmsl - 11-26-2014
Cool,
thanks you too
i have learnt a new thing today : how to read an xml file using php <!-- s:-) --><img src="{SMILIES_PATH}/icon_e_smile.gif" alt=":-)" title="Smile" /><!-- s:-) -->
Said
Re: corebosreportico - saidmsl - 11-28-2014
Hi,
for design mode (administrator) and css issues , try to remove :
$q->bootstrap_preloaded = true;
in ReporticoView.php line 80
rgds
Re: corebosreportico - omarllorens - 11-28-2014
Thanks!
You have reason, now works perfect!
Trying to add the bootstrap I've broken the css.
The project was updated again.