Error in commit

[playman]

Hi all,

The following commit has an error, when you are trying to generate a Report, the query fails:

<!-- m --><a class="postlink" href="https://github.com/tsolucio/corebos/commit/362f25b515d27292d4572cac092ca43ec5ae761f">https://github.com/tsolucio/corebos/com ... 3ec5ae761f</a><!-- m -->

the solution is add a space at start like this (between $query = and " left join...):

Code:

left join vtiger_currency_info as vtiger_currency_info$secmodule on vtiger_currency_info$secmodule.id = vtiger_salesorder.currency_id";
if(($type !== 'COLUMNSTOTOTAL') || ($type == 'COLUMNSTOTOTAL' && $where_condition == 'add'))
{        
       $query .=" left join vtiger_inventoryproductrel as vtiger_inventoryproductrelSalesOrder on vtiger_salesorder.salesorderid = vtiger_inventoryproductrelSalesOrder.id left join vtiger_products as vtiger_productsSalesOrder on vtiger_productsSalesOrder.productid = vtiger_inventoryproductrelSalesOrder.productid left join vtiger_service as vtiger_serviceSalesOrder on vtiger_serviceSalesOrder.serviceid = vtiger_inventoryproductrelSalesOrder.productid";
}
$query .=" left join vtiger_groups as vtiger_groupsSalesOrder on vtiger_groupsSalesOrder.groupid = vtiger_crmentitySalesOrder.smownerid

[omarllorens]

Hi playman.

You have reason, we had this error in PurchaseOrder, SalesOrder and Quotes.

The commit was fixed and updated.

Thanks for find this bug. <!-- s --><img src="{SMILIES_PATH}/icon_e_biggrin.gif" alt="" title="Very Happy" /><!-- s -->

Regards,

Omar.