07-30-2018, 10:13 PM
That DISTINCT is added here:
https://github.com/tsolucio/corebos/blob/master/modules/Reports/ReportRun.php#L1990
I traced it all the way back to our vtiger CRM origins:
https://github.com/tsolucio/corebos/blob/71c64d04fc4a85c3c3a9aa44cfedccf34115abc4/modules/Reports/ReportRun.php#L1826
Sincerely I don't know why it is there nor the implications of eliminating it. I remember that it is needed in the Inventory modules reports when you join on the product lines and, in fact, in the vtiger crm code you can see an if that adds it (even though it is already there!!) for these modules.
Not sure what to say and I am no fan of changing the functionality of the reporting system when every user since who knows when has been using it that way.
Comments?
https://github.com/tsolucio/corebos/blob/master/modules/Reports/ReportRun.php#L1990
I traced it all the way back to our vtiger CRM origins:
https://github.com/tsolucio/corebos/blob/71c64d04fc4a85c3c3a9aa44cfedccf34115abc4/modules/Reports/ReportRun.php#L1826
Sincerely I don't know why it is there nor the implications of eliminating it. I remember that it is needed in the Inventory modules reports when you join on the product lines and, in fact, in the vtiger crm code you can see an if that adds it (even though it is already there!!) for these modules.
Not sure what to say and I am no fan of changing the functionality of the reporting system when every user since who knows when has been using it that way.
Comments?
Joe
TSolucio
TSolucio