ModTracker works?

[playman]

Hi all,

I was testing modTracker (module that I had never dig in it) and I found that dont works, and its impossible to works with the following:

-When you activate one module to be tracked, vTiger adds a Link to module:

Code:

https://github.com/tsolucio/corebos/blob/master/modules/ModTracker/ModTracker.php - line 130.

The problem inside this function is $sequence values empty (and not 0), phpMyAdmin returns the following:

Code:

#1366 - Incorrect integer value: '' for column 'sequence' at row 1

So, my concern is if nobody notices this, or is just nobody uses this module...

Thanks.

[joebordes]

I have tested this module in the past and it worked. Truth is that we use our own history logger (which we will be adding to coreBOS soon) so we don't really use mod tracker but it did work.

Let me give it a try and get back to you

[joebordes]

I just tried and it worked correctly

[joebordes]

I had a look at the code and you are absoluetly correct, the code is wrong. The issue is that mysql must be configured with strict restrictions to give the error. By default, mysql will "understand" that the empty string is supposed to be a zero and do the insert quietly.

I have fixed the issue. Thanks <!-- s --><img src="{SMILIES_PATH}/icon_e_smile.gif" alt="" title="Smile" /><!-- s -->

[playman]

Then, should I use MySQL without strict restrictions?

[joebordes]

Yes, you should. Although the good part of not doing so is that you will catch errors like this one and we will be able to fix them

[playman]

joebordes Wrote:Yes, you should. Although the good part of not doing so is that you will catch errors like this one and we will be able to fix them

haha, good point <!-- s --><img src="{SMILIES_PATH}/icon_e_smile.gif" alt="" title="Smile" /><!-- s -->